D400 first line should end with period batch02 #25268
Conversation
edithturn
requested review from
turbaszek,
kaxil,
potiuk,
XD-DENG and
ashb
as code owners
boring-cyborg
bot
added
area:providers
area:Scheduler
airflow/executors/executor_loader.py
Outdated
| """:return: an instance of CeleryKubernetesExecutor""" | ||
| """:return: an instance of CeleryKubernetesExecutor.""" |
There was a problem hiding this comment.
These return an instance of $Executor docstrings should simply be removed, they do not really communicate anything.
| @@ -149,6 +149,8 @@ async def __aexit__(self, *err): | |||
| @staticmethod | |||
| def _parse_host(host: str) -> str: | |||
| """ | |||
| Robustness to improper connections settings provided by users. | |||
There was a problem hiding this comment.
I have trouble understanding what this means.
| Mysqldb client uses an `autocommit` method rather than an `autocommit` property. | ||
|
|
||
| The MySQLdb (mysqlclient) client uses an `autocommit` method rather |
There was a problem hiding this comment.
MySQLdb is the old name (Python 2 branch) of mysqlclient, the Python library to connect to MySQL. Since we don’t support Python 2 anymore, this should only mention mysqlclient.
|
@edithturn are you still working on this PR? |
|
@eladkal yep, I will fix this and send another batch this weekend :) |
|
Are these all the fixes? airflow/.pre-commit-config.yaml Line 258 in 733d623 to activate the this doc style? |
|
@eladkal no, there are 3000 records to correct. I am sending it in parts since sending a single PR would not be adequate. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk
force-pushed
the
D400-first-line-should-end-with-period-batch02
branch
from
7353363 to
d35290f
Compare
(cherry picked from commit 5066844)
ephraimbuddy
added
type:improvement
Related to the issue: #10742
The second batch to fix the D400 | the First line should end with a period (That is being ignored in pre-commits).
I was having an issue with helm, after running
pre-commit run --all-files, I didn't fix it, I pushed this code without that fix. It is related to this issue I described in Slack. https://apache-airflow.slack.com/archives/CCZRF2U5A/p1658682791405059.All basic pre-commits run in the commit, so it lets me push. Appreciate any feedback!