Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabricksSubmitRunOperator dbt task support #25623

Merged
merged 5 commits into from
Aug 26, 2022
Merged

DatabricksSubmitRunOperator dbt task support #25623

merged 5 commits into from
Aug 26, 2022

Conversation

gaborratky-db
Copy link
Contributor

@gaborratky-db gaborratky-db commented Aug 9, 2022

This PR adds support for the upcoming dbt_task to DatabricksSubmitRunOperator.

Databricks is launching the Public Preview of the dbt task [1] soon, and this small change adds first-class support to DatabricksSubmitRunOperator. The official documentation for the dbt task will go live as part of the Public Preview.

Please let me know if the PR should include any other changes related to supporting the new task type.

Checklist

  • Add news fragment to PR
  • Tests and PR checks pass

[1] https://www.databricks.com/blog/2022/06/29/top-5-workflows-announcements-at-data-ai-summit.html

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 9, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but would be nice to handle git source requirement

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaborratky-db gaborratky-db requested a review from alexott August 11, 2022 08:43
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaborratky-db
Copy link
Contributor Author

Hello @mik-laj, how are you? Being a first-time contributor, can I ask you to approve running the workflows so that I can address any issues the PR checks raise? The change is a minor improvement to DatabricksSubmitRunOperator.

Also, cc-ing @potiuk, who has previously handled Databricks-related PRs. Thank you all!

@mik-laj
Copy link
Member

mik-laj commented Aug 11, 2022

Ci starting.

@gaborratky-db
Copy link
Contributor Author

Hi @mik-laj, the CI checks seem to have failed on unrelated issues (docker: i/o timeout & breeze: command not found), would it be possible to run these checks again to arrive at a successful state? Thank you and have a great weekend!

@mik-laj
Copy link
Member

mik-laj commented Aug 12, 2022

Can you do a rebase?

@gaborratky-db
Copy link
Contributor Author

@mik-laj rebased to latest main

@gaborratky-db
Copy link
Contributor Author

Thanks for the suggestion, @mik-laj; the PR has passed all checks. Is there anything else I can do ahead of your code review?

@potiuk potiuk merged commit 25a9c6a into apache:main Aug 26, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 26, 2022

Awesome work, congrats on your first merged pull request!

@gaborratky-db
Copy link
Contributor Author

Thank you for the review and merging of the changes, @potiuk!

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:databricks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants