-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatabricksSubmitRunOperator dbt task support #25623
DatabricksSubmitRunOperator dbt task support #25623
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but would be nice to handle git source requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hello @mik-laj, how are you? Being a first-time contributor, can I ask you to approve running the workflows so that I can address any issues the PR checks raise? The change is a minor improvement to Also, cc-ing @potiuk, who has previously handled Databricks-related PRs. Thank you all! |
Ci starting. |
Hi @mik-laj, the CI checks seem to have failed on unrelated issues ( |
Can you do a rebase? |
@mik-laj rebased to latest |
Thanks for the suggestion, @mik-laj; the PR has passed all checks. Is there anything else I can do ahead of your code review? |
Awesome work, congrats on your first merged pull request! |
Thank you for the review and merging of the changes, @potiuk! |
This PR adds support for the upcoming
dbt_task
toDatabricksSubmitRunOperator
.Databricks is launching the Public Preview of the dbt task [1] soon, and this small change adds first-class support to
DatabricksSubmitRunOperator
. The official documentation for the dbt task will go live as part of the Public Preview.Please let me know if the PR should include any other changes related to supporting the new task type.
Checklist
[1] https://www.databricks.com/blog/2022/06/29/top-5-workflows-announcements-at-data-ai-summit.html