Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added append_job_name parameter to DataflowTemplatedJobStartOperator #25746

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Added append_job_name parameter to DataflowTemplatedJobStartOperator #25746

merged 4 commits into from
Aug 26, 2022

Conversation

Voldurk
Copy link
Contributor

@Voldurk Voldurk commented Aug 16, 2022

added possibility to pass append_job_name as DataflowHook.start_template_dataflow() argument when initializing DataflowTemplatedJobStartOperator


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

added possibility to pass append_job_name as DataflowHook.start_template_dataflow() argument when initializing DataflowTemplatedJobStartOperator
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 16, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 16, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Voldurk Voldurk marked this pull request as ready for review August 16, 2022 17:09
@Voldurk Voldurk requested a review from turbaszek as a code owner August 16, 2022 17:09
Removed optional since None is not acceptable in DataflowHook
@Voldurk Voldurk requested review from uranusjr and removed request for turbaszek August 20, 2022 13:58
@potiuk potiuk merged commit 62a46c1 into apache:main Aug 26, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 26, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants