Add pre-commit hook for custom_operator_name #25786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps @task operators to include a custom_operator_name attribute so they don't display an internal class name. The check is not extensive (it ignores many special cases such as aliases), but all decorated operators implemented following the contribution guide will be covered. And if a class does not follow the guide, it will need manual reviews to figure out a reasoning anyway.
uranusjr
requested review from
potiuk,
ashb,
mik-laj,
jedcunningham and
kaxil
as code owners
potiuk
approved these changes
Aug 18, 2022
|
nice! |
josh-fell
approved these changes
Aug 18, 2022
uranusjr
commented
Aug 19, 2022
uranusjr
deleted the
pre-commit-check-all-decorators-have-custom-operator-name
branch
ephraimbuddy
added
the
changelog:skip
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #25783 (review)
This helps
@taskoperators to include acustom_operator_nameattribute so they don't display an internal class name.The check is not extensive (it ignores many special cases such as aliases), but all decorated
operators implemented following the contribution guide will be covered. And if a class does not follow the guide, it will need manual reviews to figure out a reasoning anyway.