Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Google Protobuf for compatibility with biggtable client #25886

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 22, 2022

The bigtable client does not work well with protobuf > 3.20.0 and
it should be limited until we solve the problem.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The bigtable client does not work well with protobuf > 3.20.0 and
it should be limited until we solve the problem.
@potiuk
Copy link
Member Author

potiuk commented Aug 22, 2022

Ok. This problem is fixed (wait for PROD image succeeded tests).

@potiuk potiuk merged commit 25a9ae3 into apache:main Aug 22, 2022
@potiuk potiuk deleted the limit-protobuf branch August 22, 2022 22:33
kaxil pushed a commit to astronomer/astro-sdk that referenced this pull request Aug 24, 2022
The Biquery client does not work well with protobuf > 3.20.0

closes: #742
Also fixed in apache/airflow#25886
sunank200 added a commit to astronomer/astro-sdk that referenced this pull request Aug 24, 2022
The Biquery client does not work well with protobuf > 3.20.0

closes: #742
Also fixed in apache/airflow#25886

(cherry picked from commit d6911b3)
@mikharkiv
Copy link

Hello! Thank you for the fix!

As I can see, this affects Google provider too. Can we expect a release for Google provider with this fix?

@potiuk
Copy link
Member Author

potiuk commented Sep 14, 2022

Yes. As usual - regular provider release is coming some time soon.

@mdering
Copy link
Contributor

mdering commented Feb 9, 2023

since there isn't much here, i was wondering if this requirement is still necessary or if it could be relaxed

@potiuk
Copy link
Member Author

potiuk commented Feb 9, 2023

since there isn't much here, i was wondering if this requirement is still necessary or if it could be relaxed

I think you will never know until you try

@potiuk
Copy link
Member Author

potiuk commented Feb 9, 2023

PRs are most welcome :)

@mdering
Copy link
Contributor

mdering commented Feb 9, 2023

I'm happy to submit a PR (especially an easy one like this). before I do that, i was wondering if there was any sense of what the issue was that lead to this.

@potiuk
Copy link
Member Author

potiuk commented Feb 9, 2023

I'm happy to submit a PR (especially an easy one like this). before I do that, i was wondering if there was any sense of what the issue was that lead to this.

It did not install back then and broke our tests. The only way to check if it is fixed now is to make a PR and run the tests by doing it. We have 650+ dependencies in Airflow. No-one follows every single relase of every one of them - so no-one knows if the problem is fixed.

The only way to see if the problem is fixed is tro try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants