-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit Google Protobuf for compatibility with biggtable client #25886
Conversation
The bigtable client does not work well with protobuf > 3.20.0 and it should be limited until we solve the problem.
Ok. This problem is fixed (wait for PROD image succeeded tests). |
The Biquery client does not work well with protobuf > 3.20.0 closes: #742 Also fixed in apache/airflow#25886
The Biquery client does not work well with protobuf > 3.20.0 closes: #742 Also fixed in apache/airflow#25886 (cherry picked from commit d6911b3)
Hello! Thank you for the fix! As I can see, this affects Google provider too. Can we expect a release for Google provider with this fix? |
Yes. As usual - regular provider release is coming some time soon. |
since there isn't much here, i was wondering if this requirement is still necessary or if it could be relaxed |
I think you will never know until you try |
PRs are most welcome :) |
I'm happy to submit a PR (especially an easy one like this). before I do that, i was wondering if there was any sense of what the issue was that lead to this. |
It did not install back then and broke our tests. The only way to check if it is fixed now is to make a PR and run the tests by doing it. We have 650+ dependencies in Airflow. No-one follows every single relase of every one of them - so no-one knows if the problem is fixed. The only way to see if the problem is fixed is tro try it. |
The bigtable client does not work well with protobuf > 3.20.0 and
it should be limited until we solve the problem.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.