Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom handler param in SnowflakeOperator #25983

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Add custom handler param in SnowflakeOperator #25983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions airflow/providers/snowflake/operators/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from typing import Any, Iterable, List, Mapping, Optional, Sequence, SupportsAbs, Union
from typing import Any, Callable, Iterable, List, Mapping, Optional, Sequence, SupportsAbs, Union

from airflow.models import BaseOperator
from airflow.providers.common.sql.hooks.sql import fetch_all_handler
Expand Down Expand Up @@ -78,6 +78,8 @@ class SnowflakeOperator(BaseOperator):
through native Okta.
:param session_parameters: You can set session-level parameters at
the time you connect to Snowflake
:param handler: A Python callable that will act on cursor result.
By default, it will use ``fetchall``
"""

template_fields: Sequence[str] = ('sql',)
Expand All @@ -99,6 +101,7 @@ def __init__(
schema: Optional[str] = None,
authenticator: Optional[str] = None,
session_parameters: Optional[dict] = None,
handler: Optional[Callable] = None,
**kwargs,
) -> None:
super().__init__(**kwargs)
Expand All @@ -114,6 +117,7 @@ def __init__(
self.authenticator = authenticator
self.session_parameters = session_parameters
self.query_ids: List[str] = []
self.handler = handler

def get_db_hook(self) -> SnowflakeHook:
return get_db_hook(self)
Expand All @@ -122,7 +126,8 @@ def execute(self, context: Any):
"""Run query on snowflake"""
self.log.info('Executing: %s', self.sql)
hook = self.get_db_hook()
execution_info = hook.run(self.sql, self.autocommit, self.parameters, fetch_all_handler)
handler = self.handler or fetch_all_handler
execution_info = hook.run(self.sql, self.autocommit, self.parameters, handler)
self.query_ids = hook.query_ids

if self.do_xcom_push:
Expand Down