EMR Serverless Fix for Jobs marked as success even on failure #26218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
eladkal
reviewed
Sep 7, 2022
| @@ -650,7 +650,7 @@ def execute(self, context: 'Context') -> Dict: | |||
| 'jobRunId': response['jobRunId'], | |||
| }, | |||
| parse_response=['jobRun', 'state'], | |||
| desired_state=EmrServerlessJobSensor.TERMINAL_STATES, | |||
| desired_state=EmrServerlessJobSensor.SUCCESS_STATES, | |||
There was a problem hiding this comment.
Do we have test coverage for this?
also Operator imports from Sensor ? 🤯
The statuses should be defined on the Hook
There was a problem hiding this comment.
Examples:
airflow/airflow/providers/amazon/aws/hooks/quicksight.py
Lines 39 to 40 in 9c59831
airflow/airflow/providers/amazon/aws/hooks/emr.py
Lines 178 to 194 in 6b7a343
potiuk
approved these changes
Sep 18, 2022
|
You need to rebase and solve conflicts @syedahsn |
…ES rather than TERMINAL_STATES. This makes it so that the task is marked as a failure if the job doesn't run successfully.
Add test to cover job failure exception.
syedahsn
force-pushed
the
syedahsn/fix-emr-serverless-startjob-failure-state
branch
from
58bd33b to
8921c49
Compare
89 tasks
vandonr-amz
deleted the
syedahsn/fix-emr-serverless-startjob-failure-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was found where Airflow would mark a task as SUCCESS even if the EMR job failed.
The solution here is to set the desired state in EmrServerlessStartJobOperator to SUCCESS_STATES rather than TERMINAL_STATES. This makes it so that the task is marked as a failure if the job doesn't run successfully.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.