Make pgbouncer deployment size variable#26225
Closed
TylerLubeck wants to merge 1 commit intoapache:mainfrom
Closed
Make pgbouncer deployment size variable#26225TylerLubeck wants to merge 1 commit intoapache:mainfrom
TylerLubeck wants to merge 1 commit intoapache:mainfrom
Conversation
TylerLubeck
requested review from
dstandish and
jedcunningham
as code owners
pankajkoti
approved these changes
Sep 13, 2022
pankajkoti
requested changes
Sep 13, 2022
| "description": "Number of pgbouncer pods to deploy", | ||
| "type": "integer", | ||
| "x-docsSection": "PgBouncer", | ||
| "default": 1, |
Member
There was a problem hiding this comment.
Suggested change
| "default": 1, | |
| "default": 1 |
Static checks and tests are failing. I believe this extra , could be the reason making it an invalid json.
Member
|
Yep. needs rebasing + fixing tests. |
Member
|
#27439 made this configurable. Thanks @TylerLubeck for the PR. |
|
is it working in helm-charts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the pgbouncer deployment size configurable via helm chart. The linked issue raises concerns about running multiple pgbouncers - I believe this to only be the case when running them on a the same physical (or vm, etc) machine, and not in a kubernetes deployment.
I don't believe this will provide perfect HA - for that, anyone who raises this replica count should also be sure to enable the associated PDB to ensure some number of pgbouncer pods are always running. This also doesn't prevent breakages for anything with an active connection to pgbouncer - when one of these pods dies, those connections will be severed and will have to reconnect.
Closes #24954
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.