Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCSToBigQueryOperator Resolve max_id_key job retrieval and xcom return #26285

Merged
merged 4 commits into from
Sep 18, 2022
Merged

GCSToBigQueryOperator Resolve max_id_key job retrieval and xcom return #26285

merged 4 commits into from
Sep 18, 2022

Conversation

patricker
Copy link
Contributor

closes: #26279
closes: #26283

Multiple issues with the GCSToBigQueryOperator operator feature max_id_key.

  • BQ Job was not retrievable after execution because of a change (about 2 years ago) with @fallback_to_default_project_id
  • Even if the value was retrievable, it was not being returned/set in XCOM, as specified in the parameter docs

@patricker patricker requested a review from turbaszek as a code owner September 9, 2022 20:19
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 9, 2022
@patricker
Copy link
Contributor Author

@uranusjr Thanks for the review. I've updated my code.

@potiuk potiuk merged commit 07fe356 into apache:main Sep 18, 2022
This was referenced Sep 28, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr left review comments

@pankajkoti pankajkoti pankajkoti approved these changes

@potiuk potiuk potiuk approved these changes

@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees
No one assigned
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCSToBigQueryOperator max_id_key Not Written to XCOM GCSToBigQueryOperator max_id_key Feature Throws Error
4 participants
@patricker @potiuk @uranusjr @pankajkoti