Remove redundant catch exceptions in Amazon Log Task Handlers #26442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
provider:amazon-aws
Taragolis
force-pushed
the
aws-logging-redundant-except
branch
from
383eb67 to
19ffb25
Compare
potiuk
approved these changes
Sep 19, 2022
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove catch exception in Amazon Log Task Handlers during configure appropriate Hook.
Seem like that is old code from the time when this log handlers placed in Airflow Core (prior Airflow 2.0).
Also if we catch any error and return
Nonethan we still get an error later in a code but something like:AttributeError: 'NoneType' object has no attribute '{some_awesome_attribute}'