Refactor SlackWebhookOperator: Get rid of mandatory http-provider dependency
#26648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
force-pushed
the
slack-remove-http-as-dependency
branch
from
792c75a to
cf15073
Compare
Taragolis
requested review from
potiuk,
ashb and
jedcunningham
as code owners
potiuk
approved these changes
Sep 27, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up: #26452
Right now
SlackWebhookOperatorbased onSimpleHttpOperatorbut do not use any of parent attributes internally except http_conn_id. Mainly becauseSlackWebhookOperatorentirely overwriteexecutemethod and do not propagatedSimpleHttpOperatorattributes in hook constructor.Since last changes in
SlackWebhookHookalso do not use anything from http-provider.So there is not reason keep
apache-airflow-providers-httpas a dependency to the slack provider.