-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common sql bugfixes and improvements #26761
Common sql bugfixes and improvements #26761
Commits on Sep 27, 2022
-
Fix BigQueryTableCheckOperator test
Signed-off-by: Benji Lampel <benjamin@astronomer.io>
Configuration menu - View commit details
-
Copy full SHA for 711d6bc - Browse repository at this point
Copy the full SHA 711d6bcView commit details -
Remove job_id generation in table/col check operators
The job_id is automatically generated by hook.insert_job() if an empty string is passed, so job_id generation in the operator is removed in favor of the existing code. Signed-off-by: Benji Lampel <benjamin@astronomer.io>
Configuration menu - View commit details
-
Copy full SHA for 3c97433 - Browse repository at this point
Copy the full SHA 3c97433View commit details
Commits on Sep 28, 2022
-
SQL query building is moved to the init() method of the column and table check operators to lessen the amount of duplicate code in the child operator. It also has the added effect of, ideally, passing a more complete query to OpenLineage. In doing the above, the column check operator had to be reworked and now matches the logic of the table check operator in terms of returning multiple rows and only sending one query to the database.
Configuration menu - View commit details
-
Copy full SHA for 11a26fd - Browse repository at this point
Copy the full SHA 11a26fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for de7fafb - Browse repository at this point
Copy the full SHA de7fafbView commit details -
Add option to fail check operators without retries
Adds a new parameter, retry_on_failure, and a new function to determine if operators should retry or not on test failure.
Configuration menu - View commit details
-
Copy full SHA for b315f0b - Browse repository at this point
Copy the full SHA b315f0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a560b45 - Browse repository at this point
Copy the full SHA a560b45View commit details
Commits on Sep 29, 2022
-
Update airflow/providers/common/sql/operators/sql.py
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c987fd - Browse repository at this point
Copy the full SHA 8c987fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4364a39 - Browse repository at this point
Copy the full SHA 4364a39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30839fb - Browse repository at this point
Copy the full SHA 30839fbView commit details -
Update tests and operator code
Updates tests to reflect changes in operator code, and fixed bugs in operators as well. Mainly moving the code to check for failed tests into the column and table check operators as it works slightly differently for each and doesn't make much sense as a top-level function.
Configuration menu - View commit details
-
Copy full SHA for a787d3a - Browse repository at this point
Copy the full SHA a787d3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9005a4b - Browse repository at this point
Copy the full SHA 9005a4bView commit details
Commits on Sep 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c00c934 - Browse repository at this point
Copy the full SHA c00c934View commit details
Commits on Oct 3, 2022
-
Fix BigQueryTableCheckOperator test
Signed-off-by: Benji Lampel <benjamin@astronomer.io>
Configuration menu - View commit details
-
Copy full SHA for b2eb10a - Browse repository at this point
Copy the full SHA b2eb10aView commit details -
Remove job_id generation in table/col check operators
The job_id is automatically generated by hook.insert_job() if an empty string is passed, so job_id generation in the operator is removed in favor of the existing code. Signed-off-by: Benji Lampel <benjamin@astronomer.io>
Configuration menu - View commit details
-
Copy full SHA for e13c59c - Browse repository at this point
Copy the full SHA e13c59cView commit details -
SQL query building is moved to the init() method of the column and table check operators to lessen the amount of duplicate code in the child operator. It also has the added effect of, ideally, passing a more complete query to OpenLineage. In doing the above, the column check operator had to be reworked and now matches the logic of the table check operator in terms of returning multiple rows and only sending one query to the database.
Configuration menu - View commit details
-
Copy full SHA for 708ad7a - Browse repository at this point
Copy the full SHA 708ad7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62c01bf - Browse repository at this point
Copy the full SHA 62c01bfView commit details -
Add option to fail check operators without retries
Adds a new parameter, retry_on_failure, and a new function to determine if operators should retry or not on test failure.
Configuration menu - View commit details
-
Copy full SHA for f66bfe4 - Browse repository at this point
Copy the full SHA f66bfe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef7c2a1 - Browse repository at this point
Copy the full SHA ef7c2a1View commit details -
Update airflow/providers/common/sql/operators/sql.py
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 586dc39 - Browse repository at this point
Copy the full SHA 586dc39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 419b167 - Browse repository at this point
Copy the full SHA 419b167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55f9bb8 - Browse repository at this point
Copy the full SHA 55f9bb8View commit details -
Update tests and operator code
Updates tests to reflect changes in operator code, and fixed bugs in operators as well. Mainly moving the code to check for failed tests into the column and table check operators as it works slightly differently for each and doesn't make much sense as a top-level function.
Configuration menu - View commit details
-
Copy full SHA for e8ce879 - Browse repository at this point
Copy the full SHA e8ce879View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e8dcd9 - Browse repository at this point
Copy the full SHA 3e8dcd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce4b6f - Browse repository at this point
Copy the full SHA 0ce4b6fView commit details -
Merge branch 'common_sql_bugfixes_and_improvements' of github.com:den…
…imalpaca/airflow into common_sql_bugfixes_and_improvements
Configuration menu - View commit details
-
Copy full SHA for a7c5bd2 - Browse repository at this point
Copy the full SHA a7c5bd2View commit details
Commits on Oct 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bf54c24 - Browse repository at this point
Copy the full SHA bf54c24View commit details
Commits on Oct 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c3e64ea - Browse repository at this point
Copy the full SHA c3e64eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1262e6 - Browse repository at this point
Copy the full SHA b1262e6View commit details
Commits on Oct 7, 2022
-
Update operator logic and tests
Adds "where" option in checks dictionaries for column and table operators, which may be renamed. This allows for check-level partitioning, whereas the partition_clause param will always be for all checks. New tests are added for this addition.
Configuration menu - View commit details
-
Copy full SHA for 1a52335 - Browse repository at this point
Copy the full SHA 1a52335View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62fc3e4 - Browse repository at this point
Copy the full SHA 62fc3e4View commit details -
Merge branch 'common_sql_bugfixes_and_improvements' of github.com:den…
…imalpaca/airflow into common_sql_bugfixes_and_improvements
Configuration menu - View commit details
-
Copy full SHA for a60e3e0 - Browse repository at this point
Copy the full SHA a60e3e0View commit details -
Add testing for column check operator and line edits
Cleans up operator and adds testing for new generator function.
Configuration menu - View commit details
-
Copy full SHA for 46ca885 - Browse repository at this point
Copy the full SHA 46ca885View commit details
Commits on Oct 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2014f5e - Browse repository at this point
Copy the full SHA 2014f5eView commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9014f65 - Browse repository at this point
Copy the full SHA 9014f65View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee5f516 - Browse repository at this point
Copy the full SHA ee5f516View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdccba7 - Browse repository at this point
Copy the full SHA bdccba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 888160a - Browse repository at this point
Copy the full SHA 888160aView commit details
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fe8ba70 - Browse repository at this point
Copy the full SHA fe8ba70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e159c0 - Browse repository at this point
Copy the full SHA 3e159c0View commit details -
Merge branch 'common_sql_bugfixes_and_improvements' of github.com:den…
…imalpaca/airflow into common_sql_bugfixes_and_improvements
Configuration menu - View commit details
-
Copy full SHA for c3214c2 - Browse repository at this point
Copy the full SHA c3214c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67c43c8 - Browse repository at this point
Copy the full SHA 67c43c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37c704f - Browse repository at this point
Copy the full SHA 37c704fView commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6368a95 - Browse repository at this point
Copy the full SHA 6368a95View commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4b2fc34 - Browse repository at this point
Copy the full SHA 4b2fc34View commit details -
Add new accept_none argument to column check operator
The new argument, defaulting to true, will convert Nones returned from the query to 0s so numeric calculations can be performed correctly. This allows empty tables to be handled as a row of zeroes. Additional documentation is also supplied
Configuration menu - View commit details
-
Copy full SHA for 9367ab9 - Browse repository at this point
Copy the full SHA 9367ab9View commit details
Commits on Oct 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8745d53 - Browse repository at this point
Copy the full SHA 8745d53View commit details
Commits on Oct 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 84e4e01 - Browse repository at this point
Copy the full SHA 84e4e01View commit details -
Configuration menu - View commit details
-
Copy full SHA for e46c233 - Browse repository at this point
Copy the full SHA e46c233View commit details
Commits on Oct 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4835d61 - Browse repository at this point
Copy the full SHA 4835d61View commit details
Commits on Oct 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1de2b51 - Browse repository at this point
Copy the full SHA 1de2b51View commit details
Commits on Oct 26, 2022
-
Fix BigQueryTableCheckOperator test
Signed-off-by: Benji Lampel <benjamin@astronomer.io>
Configuration menu - View commit details
-
Copy full SHA for 43a33c4 - Browse repository at this point
Copy the full SHA 43a33c4View commit details -
Remove job_id generation in table/col check operators
The job_id is automatically generated by hook.insert_job() if an empty string is passed, so job_id generation in the operator is removed in favor of the existing code. Signed-off-by: Benji Lampel <benjamin@astronomer.io>
Configuration menu - View commit details
-
Copy full SHA for c761c05 - Browse repository at this point
Copy the full SHA c761c05View commit details -
SQL query building is moved to the init() method of the column and table check operators to lessen the amount of duplicate code in the child operator. It also has the added effect of, ideally, passing a more complete query to OpenLineage. In doing the above, the column check operator had to be reworked and now matches the logic of the table check operator in terms of returning multiple rows and only sending one query to the database.
Configuration menu - View commit details
-
Copy full SHA for d4758cb - Browse repository at this point
Copy the full SHA d4758cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc87c3a - Browse repository at this point
Copy the full SHA cc87c3aView commit details -
Add option to fail check operators without retries
Adds a new parameter, retry_on_failure, and a new function to determine if operators should retry or not on test failure.
Configuration menu - View commit details
-
Copy full SHA for c5d7422 - Browse repository at this point
Copy the full SHA c5d7422View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8080fc6 - Browse repository at this point
Copy the full SHA 8080fc6View commit details -
Update airflow/providers/common/sql/operators/sql.py
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 625d2b8 - Browse repository at this point
Copy the full SHA 625d2b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f3f400 - Browse repository at this point
Copy the full SHA 4f3f400View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9400414 - Browse repository at this point
Copy the full SHA 9400414View commit details -
Update tests and operator code
Updates tests to reflect changes in operator code, and fixed bugs in operators as well. Mainly moving the code to check for failed tests into the column and table check operators as it works slightly differently for each and doesn't make much sense as a top-level function.
Configuration menu - View commit details
-
Copy full SHA for 0a794fb - Browse repository at this point
Copy the full SHA 0a794fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for efa1f79 - Browse repository at this point
Copy the full SHA efa1f79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 213d0a2 - Browse repository at this point
Copy the full SHA 213d0a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12c7cef - Browse repository at this point
Copy the full SHA 12c7cefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ff14c2 - Browse repository at this point
Copy the full SHA 1ff14c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e36aaf5 - Browse repository at this point
Copy the full SHA e36aaf5View commit details -
Update operator logic and tests
Adds "where" option in checks dictionaries for column and table operators, which may be renamed. This allows for check-level partitioning, whereas the partition_clause param will always be for all checks. New tests are added for this addition.
Configuration menu - View commit details
-
Copy full SHA for ac4fca4 - Browse repository at this point
Copy the full SHA ac4fca4View commit details -
Add testing for column check operator and line edits
Cleans up operator and adds testing for new generator function.
Configuration menu - View commit details
-
Copy full SHA for 8beb8ab - Browse repository at this point
Copy the full SHA 8beb8abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 385317f - Browse repository at this point
Copy the full SHA 385317fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 979def5 - Browse repository at this point
Copy the full SHA 979def5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 586f6b4 - Browse repository at this point
Copy the full SHA 586f6b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c060da0 - Browse repository at this point
Copy the full SHA c060da0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8498cbf - Browse repository at this point
Copy the full SHA 8498cbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a15e1a2 - Browse repository at this point
Copy the full SHA a15e1a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f9bce3 - Browse repository at this point
Copy the full SHA 0f9bce3View commit details -
Add new accept_none argument to column check operator
The new argument, defaulting to true, will convert Nones returned from the query to 0s so numeric calculations can be performed correctly. This allows empty tables to be handled as a row of zeroes. Additional documentation is also supplied
Configuration menu - View commit details
-
Copy full SHA for 3140a02 - Browse repository at this point
Copy the full SHA 3140a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c7b51 - Browse repository at this point
Copy the full SHA 09c7b51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 473f5ba - Browse repository at this point
Copy the full SHA 473f5baView commit details -
Merge branch 'common_sql_bugfixes_and_improvements' of github.com:den…
…imalpaca/airflow into common_sql_bugfixes_and_improvements
Configuration menu - View commit details
-
Copy full SHA for 8299a55 - Browse repository at this point
Copy the full SHA 8299a55View commit details