Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Trino version to fix non-working DML queries #27168

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

alexandermalyga
Copy link
Contributor

@alexandermalyga alexandermalyga commented Oct 20, 2022

closes: #26774

Issue fixed on Trino's side: trinodb/trino-python-client#220

@eladkal
Copy link
Contributor

eladkal commented Oct 20, 2022

Issue reports the issue also on PrestoHook.
Is there a fix for it?

@alexandermalyga
Copy link
Contributor Author

Issue reports the issue also on PrestoHook. Is there a fix for it?

No, I've tested it with a local Trino deployment and the latest Presto Python client still has the old problematic behaviour.

@eladkal
Copy link
Contributor

eladkal commented Oct 20, 2022

Issue reports the issue also on PrestoHook. Is there a fix for it?

No, I've tested it with a local Trino deployment and the latest Presto Python client still has the old problematic behaviour.

Is there an open github issue we can track?

@alexandermalyga
Copy link
Contributor Author

Issue reports the issue also on PrestoHook. Is there a fix for it?

No, I've tested it with a local Trino deployment and the latest Presto Python client still has the old problematic behaviour.

Is there an open github issue we can track?

Found this open issue since 2019: prestodb/presto-python-client#84
I could try to bring attention to it, but from the comments it doesn't look that they're considering implementing a fix.

@uranusjr
Copy link
Member

Please run pre-commit locally to fix the static checks.

@alexandermalyga
Copy link
Contributor Author

Should the Trino provider version be bumped to 4.1.1 in this PR?

@eladkal
Copy link
Contributor

eladkal commented Oct 21, 2022

Should the Trino provider version be bumped to 4.1.1 in this PR?

no. This action is done by release manager as only during release we know if it's patch/minor/major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trino and Presto hooks do not properly execute statements other than SELECT
4 participants