Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unused SQLCheckOperator.parameters in SQLCheckOperator.execute. #27599

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Use unused SQLCheckOperator.parameters in SQLCheckOperator.execute. #27599

merged 7 commits into from
Nov 14, 2022

Conversation

wjmolina
Copy link
Contributor

The method execute of the class SQLCheckOperator is not using the property parameters.

@wjmolina wjmolina requested a review from eladkal as a code owner November 10, 2022 18:57
@uranusjr
Copy link
Member

Can we have a test for this please?

@wjmolina wjmolina requested review from uranusjr and removed request for potiuk, turbaszek, mik-laj and eladkal November 11, 2022 03:22
uranusjr
uranusjr requested changes Nov 11, 2022
View reviewed changes
airflow/providers/common/sql/operators/sql.py Outdated Show resolved Hide resolved
airflow/providers/common/sql/operators/sql.py Outdated Show resolved Hide resolved
@wjmolina wjmolina requested a review from eladkal November 14, 2022 18:09
eladkal
eladkal approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge when CI is green

@potiuk potiuk merged commit 3ae98b8 into apache:main Nov 14, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 14, 2022

Awesome work, congrats on your first merged pull request!

@potiuk potiuk mentioned this pull request Nov 15, 2022
Closed
@wjmolina wjmolina deleted the patch-1 branch November 15, 2022 17:11
@potiuk potiuk mentioned this pull request Mar 4, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal approved these changes

@uranusjr uranusjr uranusjr approved these changes

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:providers provider:common-sql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjmolina @uranusjr @potiuk @eladkal