Correct repo example for cloning via ssh - comments in helm chart#27671
Merged
jedcunningham merged 1 commit intoapache:mainfrom Nov 15, 2022
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
potiuk
approved these changes
Nov 14, 2022
Contributor
Author
|
Hi @potiuk thanks for approving! I know it is tiny but it will save a lot of time for those who will stumble upon the same issue. Can it be merged, so I can forget about that? |
jedcunningham
approved these changes
Nov 15, 2022
|
Awesome work, congrats on your first merged pull request! |
Member
|
Thanks @morkot! Congrats on your first commit 🎉 |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
values.yamlfile of helm chart there are two options for the git clone url one if which doesn't work. When anyone generates values file using commandhelm show values apache-airflow/airflow > values.yamand uses wrong example it leads to errors in git-sync.Related:
#21970
#26632