Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed D400 for multiple folders #27767

Merged
merged 38 commits into from
Nov 27, 2022

Conversation

bdsoha
Copy link
Contributor

@bdsoha bdsoha commented Nov 18, 2022

Completed D400 for:

  • airflow/__init__.py
  • airflow/__main__.py
  • airflow/dag_processing/*
  • airflow/logging_config.py
  • airflow/plugins_manager.py
  • airflow/providers_manager.py
  • airflow/sentry.py
  • airflow/settings.py
  • airflow/stats.py
  • airflow/templates.py
  • airflow/typing_compat.py

Related to #10742 .

@bdsoha bdsoha force-pushed the feature/fix-pydocstyle-d400-8 branch from 1d3bd29 to f8fa843 Compare November 18, 2022 06:26
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/providers_manager.py Outdated Show resolved Hide resolved
airflow/settings.py Outdated Show resolved Hide resolved
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
airflow/plugins_manager.py Outdated Show resolved Hide resolved
airflow/plugins_manager.py Outdated Show resolved Hide resolved
bdsoha and others added 9 commits November 18, 2022 10:09
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@uranusjr
Copy link
Member

@bdsoha You can bulk-apply all suggestions from the “files” tab instead of adding individual commits.

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@bdsoha
Copy link
Contributor Author

bdsoha commented Nov 18, 2022

@bdsoha You can bulk-apply all suggestions from the “files” tab instead of adding individual commits.

Thanks for the tip, will use it next time.

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@bdsoha bdsoha force-pushed the feature/fix-pydocstyle-d400-8 branch from 11ad249 to ec6352e Compare November 18, 2022 08:36
@potiuk
Copy link
Member

potiuk commented Nov 18, 2022

sounds like new warning generated when importing providers. ?

@bdsoha
Copy link
Contributor Author

bdsoha commented Nov 18, 2022

@potiuk Any suggestions? Rebase?

@potiuk
Copy link
Member

potiuk commented Nov 18, 2022

Or rather fix it. Not sure where it came from though - it should not happen normally but might be triggered by some of your changes - if it does not happen in main, just follow the instructions printed with the error.

@bdsoha bdsoha force-pushed the feature/fix-pydocstyle-d400-8 branch from ec6352e to 1fbd011 Compare November 19, 2022 16:17
bdsoha and others added 9 commits November 20, 2022 07:50
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@bdsoha bdsoha force-pushed the feature/fix-pydocstyle-d400-8 branch from 1fbd011 to 8f485eb Compare November 20, 2022 05:50
@potiuk
Copy link
Member

potiuk commented Nov 27, 2022

Needs rebase I am afraid (conflicts after the merge of previous D400 change) @bdsoha

@bdsoha
Copy link
Contributor Author

bdsoha commented Nov 27, 2022

@potiuk All green...

@potiuk potiuk merged commit 70a9980 into apache:main Nov 27, 2022
@bdsoha bdsoha deleted the feature/fix-pydocstyle-d400-8 branch November 28, 2022 05:14
@ephraimbuddy ephraimbuddy added this to the Airflow 2.6.0 milestone Jan 9, 2023
@ephraimbuddy ephraimbuddy added type:improvement Changelog: Improvements type:misc/internal Changelog: Misc changes that should appear in change log and removed type:improvement Changelog: Improvements labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:plugins type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants