Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postgres from K8S venv #28323

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 13, 2022

While postgres has always been in the k8s venv used for K8S tests, it seems it is not needed there at all. Not sure if it was ever needed in fact (maybe some super old historical version of those tests needed it). This removes postgres from the requirements for the venv.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

While postgres has always been in the k8s venv used for K8S tests,
it seems it is not needed there at all. Not sure if it was
ever needed in fact (maybe some super old historical version of
those tests needed it). This removes postgres from the requirements
for the venv.
@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Dec 13, 2022
@potiuk potiuk requested review from ashb and mik-laj as code owners December 13, 2022 02:12
@potiuk potiuk requested a review from Taragolis December 13, 2022 02:56
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it doesn't need 😄

@potiuk potiuk merged commit db5995a into apache:main Dec 13, 2022
@potiuk potiuk deleted the remove-postgres-from-k8s-venv branch December 13, 2022 09:01
ephraimbuddy pushed a commit that referenced this pull request Jan 12, 2023
While postgres has always been in the k8s venv used for K8S tests,
it seems it is not needed there at all. Not sure if it was
ever needed in fact (maybe some super old historical version of
those tests needed it). This removes postgres from the requirements
for the venv.

(cherry picked from commit db5995a)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.5.1 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants