Skip to content

Fix helm chart create scheduler service to serve task logs for LocalKubernetesExecutor #28828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Jan 18, 2023
Merged

Fix helm chart create scheduler service to serve task logs for LocalKubernetesExecutor #28828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e53e4a
create scheduler service for serve task_logs for specific executors
Jan 10, 2023
e29da2a
removed sequential executor
Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/templates/scheduler/scheduler-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
################################
## Airflow Scheduler Service
#################################
{{- if eq .Values.executor "LocalExecutor" }}
{{- if or (eq .Values.executor "LocalExecutor") (eq .Values.executor "LocalKubernetesExecutor") }}
kind: Service
apiVersion: v1
metadata:
Expand Down
27 changes: 27 additions & 0 deletions tests/charts/test_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,33 @@ def test_should_add_component_specific_labels(self):


class TestSchedulerService:
@pytest.mark.parametrize(
"executor, creates_service",
[
("LocalExecutor", True),
("CeleryExecutor", False),
("CeleryKubernetesExecutor", False),
("KubernetesExecutor", False),
("LocalKubernetesExecutor", True),
],
)
def test_should_create_scheduler_service_for_specific_executors(self, executor, creates_service):
docs = render_chart(
values={
"executor": executor,
"scheduler": {
"labels": {"test_label": "test_label_value"},
},
},
show_only=["templates/scheduler/scheduler-service.yaml"],
)
if creates_service:
assert jmespath.search("kind", docs[0]) == "Service"
assert "test_label" in jmespath.search("metadata.labels", docs[0])
assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
else:
assert docs == []

def test_should_add_component_specific_labels(self):
docs = render_chart(
values={
Expand Down