Fix incorrect comments in worker-kedaautoscaler.yaml#28858
Merged
jedcunningham merged 2 commits intoapache:mainfrom Jan 12, 2023
Merged
Fix incorrect comments in worker-kedaautoscaler.yaml#28858jedcunningham merged 2 commits intoapache:mainfrom
jedcunningham merged 2 commits intoapache:mainfrom
Conversation
Comment on lines
40
to
41
Member
There was a problem hiding this comment.
Suggested change
| pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 5 seconds | |
| cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 30 seconds | |
| pollingInterval: {{ .Values.workers.keda.pollingInterval }} | |
| cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} |
Let's actually just remove it completely - we don't really do this elsewhere and they are just asking to become out of sync.
Member
Author
There was a problem hiding this comment.
Done, thanks for the suggestions : )
Member
There was a problem hiding this comment.
Suggested change
| maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} # Optional. Default: 10 | |
| maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} |
d1a885f to
598a2f3
Compare
jedcunningham
approved these changes
Jan 12, 2023
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some comments in
worker-kedaautoscaler.yamlare inconsistent with corresponding default values invalues.yaml. This PR corrects those comments.airflow/chart/templates/workers/worker-kedaautoscaler.yaml
Lines 40 to 43 in 493b433
airflow/chart/values.yaml
Lines 498 to 513 in 493b433