Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferrable TriggerDagRunOperator #30292

Merged
merged 18 commits into from
Mar 29, 2023
Merged

Deferrable TriggerDagRunOperator #30292

merged 18 commits into from
Mar 29, 2023

Conversation

dylanbstorey
Copy link
Contributor

@dylanbstorey dylanbstorey commented Mar 25, 2023


Makes the TriggerDagRunOperator deferrable by adding a new keyword argument , defer, to the class signature.

Utilizes the DagStateTrigger for detecting when to return on completion.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Mar 25, 2023
@dylanbstorey dylanbstorey changed the title Deferable trigger Deferable TriggerDagRunOperator Mar 25, 2023
@dylanbstorey dylanbstorey changed the title Deferable TriggerDagRunOperator Deferrable TriggerDagRunOperator Mar 25, 2023
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
dylanbstorey and others added 9 commits March 25, 2023 11:37
Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
airflow/operators/trigger_dagrun.py Outdated Show resolved Hide resolved
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is not related to this PR. LGTM

@eladkal eladkal added this to the Airflow 2.6.0 milestone Mar 29, 2023
@BasPH BasPH merged commit 1e7849e into apache:main Mar 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 29, 2023

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Apr 11, 2023
@dylanbstorey dylanbstorey deleted the deferable-trigger branch April 16, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants