Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Mandatory Encryption in Neo4jHook #30418

Merged
merged 9 commits into from
Apr 21, 2023
Merged

Removed Mandatory Encryption in Neo4jHook #30418

merged 9 commits into from
Apr 21, 2023

Conversation

eldar-elne
Copy link
Contributor

@eldar-elne eldar-elne commented Apr 1, 2023

This PR fixes the issue on Neo4jHook implementation when connecting with a self-signed certificate.

closes: #30153
related: #30153

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 1, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal
Copy link
Contributor

eladkal commented Apr 21, 2023

@eldar-eln-bigabid tests are failing.
can you please take a look?

@hussein-awala hussein-awala merged commit cd45842 into apache:main Apr 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 21, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@hussein-awala
Copy link
Member

@eldar-eln-bigabid congrats on your first merged PR! you can check the latest version of unit tests for future contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Neo4j provider using some schemes
3 participants