Add CloudBuild build id log #30516
Merged
Add CloudBuild build id log #30516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
pankajastro
reviewed
Apr 14, 2023
| return operation, id_ | ||
|
|
||
| @GoogleBaseHook.fallback_to_default_project_id | ||
| def create_build( |
There was a problem hiding this comment.
maybe need to deprecated it first and we should remove it only in major release
There was a problem hiding this comment.
@pankajastro
Thank you for your review. I have reverted the changes based on your feedback.
If you happen to know, could you please tell me what is the common way to deprecate a method in Airflow?
There was a problem hiding this comment.
It depends - look at similar cases where DeprecationWarning is raised - just search in our codebase.
pankajastro
reviewed
May 5, 2023
| @@ -207,6 +209,11 @@ def create_build( | |||
| :param metadata: Optional, additional metadata that is provided to the method. | |||
|
|
|||
| """ | |||
| warnings.warn( | |||
There was a problem hiding this comment.
since we have merged #30975 so we should use AirflowProviderDeprecationWarning.
There was a problem hiding this comment.
Thank you I fixed it.
potiuk
approved these changes
May 16, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logging for CloudBuild build id.
This fix makes it easier to investigate when CloudBuild fails, etc.
Summary
Remove hooks.create_build as it was unused