Deprecate Databricks Deferrable Operator #30761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
commented
Apr 20, 2023
|
|
||
| class DatabricksSubmitRunDeferrableOperator(DatabricksSubmitRunOperator): | ||
| """Deferrable version of ``DatabricksSubmitRunOperator``""" | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| warnings.warn( |
There was a problem hiding this comment.
this is just a kind of warning, but please let me know I should remove execute and execute_complete from DatabricksRunNowDeferrableOperator
pankajastro
force-pushed
the
deprecate_databricks_async_op
branch
from
bf991ea
to
978f0ba
Compare
potiuk
approved these changes
Apr 22, 2023
potiuk
approved these changes
Apr 22, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to deprecate
DatabricksSubmitRunDeferrableOperatorandDatabricksRunNowDeferrableOperatorand add a paramdeferrableinDatabricksSubmitRunOperatorandDatabricksRunNowOperator.The default value of the
deferrableparam is false.Since at most of the places for the async operator, we have deferrable param.
so this will make the Databricks provider more consistent with other providers.
In future, we can remove the deprecated one so we will have fewer operators which is good.
This will also give a more logical easy way to navigate and figure out
if the operator supports the deferrable mode or not and
I can set deferrable=True/False dynamically for all operator in my dag
if
deferrableattr exist in the operator^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.