-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Latest Service Bus Library #31168
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Oh yes It should be just-in-time for the Python 3.11 support #27264 which we waited with for #30067 (going to be merged in the next few days). So it might be very handy (though amqp is currently used by redis - but we are also upgrading this one in #31279 so maybe we can combine all those changes. |
Ah no - that was rabbitmq let me see. |
Ah no - |
yeah 🙂. Both Event Hubs and Service Bus Python clients no longer use uamqp. This should ease up a lot of things for yall like python version upgrades, running on ARM etc. Glad we could help |
I just rebased this PR to the latest main - it has been 65 commits behind and the error generated was likely coming from that, but I wanted to be absolutely sure. Just for the future - There is also a risk that someone already merged-in PRs tha will make tests start to fail after merging, so rebasing is good to do in almost any case when you push a fix. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This PR updates the azure-service version to 7.10.0. The new version is now using a new all python based AMQP stack, which means uamqp is no longer required and opens up the library overall to be run in a wide variety of architectures, OSes etc. There are some performance improvements when receiving messages from queues & topics.
I had seen an old issue yall had mentioned and this version bump will help with that :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.