K8s hook should still work with missing default conn #31187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common when using KPO / K8s hook to want to simply use the RBAC of the cluster. This was the default behavior prior to apache#28848. After that change, users are forced to add a k8s connection or their dags will break. To fix this, in the special case where conn_id=="kubernetes_default", if the conn is missing, we ignore the failure.
boring-cyborg
bot
added
provider:cncf-kubernetes
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
hussein-awala
approved these changes
May 10, 2023
|
Ah it's already changed 😄 |
jedcunningham
approved these changes
May 10, 2023
jedcunningham
deleted the
k8s-hook-should-still-work-with-missing-default-conn-id
branch
eladkal
reviewed
May 11, 2023
| @@ -39,6 +39,14 @@ Features | |||
| * ``Deprecate 'skip_exit_code' in 'DockerOperator' and 'KubernetesPodOperator' (#30733)`` | |||
| * ``Remove skip_exit_code from KubernetesPodOperator (#30788)`` | |||
|
|
|||
| 6.1.0 | |||
There was a problem hiding this comment.
This is duplicate.
I will fix it during release
2 tasks
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common when using KPO / K8s hook to want to simply use the RBAC of the cluster. This was the default behavior prior to #28848. After that change, users are forced to add a k8s connection or their dags will break.
To fix this, in the special case where conn_id=="kubernetes_default", if the conn is missing, we ignore the failure.