Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't present an undefined execution date #31196

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

evanmiller
Copy link
Contributor

If a task had e.g. entered a Failed state but had not yet started, the UI would display the current time as the "Run:" time. This is confusing, as a new timestamp appears each time the user hovers.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

If a task had entered a Failed state but had not yet started, the UI
would display the current time as the "Run:" time. This is confusing.
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 11, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 11, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

Hmm, a ti should have an execution date when it is created, and having undefined here seems wrong in the first place. Maybe we should fix the root cause instead of hiding it.

@evanmiller
Copy link
Contributor Author

Hmm, a ti should have an execution date when it is created, and having undefined here seems wrong in the first place. Maybe we should fix the root cause instead of hiding it.

The root cause may be very complex; this is a simple fix to prevent operator confusion.

@bbovenzi
Copy link
Contributor

We show the execution date in a lot of places though. How does the rest of the UI look like for that task instance?

@evanmiller
Copy link
Contributor Author

We show the execution date in a lot of places though. How does the rest of the UI look like for that task instance?

Seems OK? I think the formatting issue is that moment(undefined) uses the current time.

@evanmiller
Copy link
Contributor Author

Bump

@bbovenzi bbovenzi added this to the Airflow 2.6.2 milestone Jun 7, 2023
@bbovenzi bbovenzi merged commit e162074 into apache:main Jun 7, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 7, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@evanmiller evanmiller deleted the dont-format-null-execution-date branch June 7, 2023 18:39
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
If a task had entered a Failed state but had not yet started, the UI
would display the current time as the "Run:" time. This is confusing.

(cherry picked from commit e162074)
eladkal pushed a commit that referenced this pull request Jun 9, 2023
If a task had entered a Failed state but had not yet started, the UI
would display the current time as the "Run:" time. This is confusing.

(cherry picked from commit e162074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants