Standardize Slack Notifier #31244
Merged
Standardize Slack Notifier #31244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not have `slack_` prefix
potiuk
approved these changes
May 12, 2023
vincbeck
reviewed
May 12, 2023
| class SlackNotifier(BaseNotifier): | ||
| """ | ||
| Slack BaseNotifier | ||
|
|
There was a problem hiding this comment.
I think we should reference the documentation like we do with operators, sensors, ...
Suggested change
| .. seealso:: | |
| For more information on how to use this notifier, take a look at the guide: | |
| :ref:`howto/notifier:SlackNotifier` | |
| @@ -20,7 +20,7 @@ How-to Guide for Slack notifications | |||
|
|
|||
There was a problem hiding this comment.
I cannot add a comment before "How-to Guide for Slack notifications" but that's where I'd put it
Suggested change
| .. _howto/notifier:SlackNotifier: | |
|
Oops, bad timing :D |
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not have
slack_prefix