-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize deferrable mode execution for BigQueryInsertJobOperator
#31249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Google (including GCP) related issues
labels
May 12, 2023
phanikumv
changed the title
Optimize deferred mode execution for
Optimize deferrable mode execution for May 12, 2023
BigQueryInsertJobOperator
BigQueryInsertJobOperator
shahar1
reviewed
May 12, 2023
pankajkoti
reviewed
May 15, 2023
sunank200
reviewed
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add the documentation changes along with example DAGs
Documentation and example DAG already added in a previous PR. Check out #26433 |
pankajkoti
reviewed
May 19, 2023
phanikumv
force-pushed
the
bq_op
branch
3 times, most recently
from
May 25, 2023 03:38
a0ec08d
to
d5c2587
Compare
pankajkoti
approved these changes
May 25, 2023
ephraimbuddy
approved these changes
May 25, 2023
2 tasks
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies if a BigQuery job has already completed before deferring the task to prevent unnecessary deferring. This way, we can skip deferring the task if it has already been finished.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.