-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-select, proposals and labels for trigger form #31441
Add multi-select, proposals and labels for trigger form #31441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good. :)
I just have an issue with multiselect field:
- Select multiple value in the
Multi Select *:
- Submit the run
- Try to trigger again this dag using previous configuration we made for the 1st run
- The field is not properly populated. It uses the default value for the param, while we are using the previous configuration. The
Generated Configuration JSON
though is correct (with values from the former run)
…elect-and-labels-for-trigger-forms
You found a generic bug before this PR actually - never have seen this before. Thanks for finding. Select boxes anyway were not correctly re-populated with data when recent config was selected. Fixed now. (Detail: Just setting the |
…elect-and-labels-for-trigger-forms
closes: #31869 |
closes: #31440
related: #31301 #31399
This PR adds three new (small) features into the Trigger DAG UI form for increased usability and new (missing) features:
enum
) display labels can be added to separate picked value and display text in dropdown viavalues_display
property.enum
s now the attributeexamples
can be used which are used to present proposals while typingenum
s with single values need to be used). These are a combination ofarray
type andexamples
.Tutorial is adjusted with examples for the new features, UI looks like this for the three new options:
This PR overlaps a bit with https://github.com/apache/airflow/31400 so the other should be merged first and then this needs to be adjusted.