-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gantt tab #31806
New gantt tab #31806
Conversation
Whoa. I don't have skills to review it but the screenshots looks like #protm |
this looks really good! |
my eyes 🤩🤩🤩🤩🤩 |
WOW and only 440 LoC! This smells like PR of the month is coming :-D |
Ready for review although I'm still working to improve the synced scroll behavior. |
set axes support task groups synced scrolling clean up var names and height/scroll logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tested locally and seems nice. 🎉
I just have issues scrolling the gantt. (scroll bars are not working for me), also I have vertical scroll when there is plenty of space vertically to render the Gantt chart. (scrollbar are unresponsive, both with the scroll wheel and by click/drag on it, tested on chrome and firefox on ubuntu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In this case I think we could even remove the original Gantt chart entirely. Happy to make that a separate PR if you want. (Either way, when we delete that we should redirect the old URL to the new react-based one)
+1 |
+1 |
New Gantt Chart in grid new tabs
Closes: #19940
Sync scrolling with grid:
Support task groups and sync with grid:
Sync task/run selection with grid:
To Do:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.