Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selective checks skipping provider tests in non main branch #31821

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 9, 2023


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from eladkal June 9, 2023 20:29
@potiuk potiuk force-pushed the fix-skipping-provider-tests-for-non-main-branch branch from 71bc9f1 to 7d819dc Compare June 9, 2023 20:32
@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2023

Finding while building 2.6.2. It caused failed provider tests

@potiuk potiuk force-pushed the fix-skipping-provider-tests-for-non-main-branch branch from 7d819dc to 2cfc527 Compare June 9, 2023 21:16
When CI runs in non-main branch, some provider precommits and provider
tests should be disabled. There was a typo that prevented this from
happening, also names of the pre-commits changed.
@potiuk potiuk force-pushed the fix-skipping-provider-tests-for-non-main-branch branch from 2cfc527 to 8897fb8 Compare June 9, 2023 21:20
@potiuk potiuk merged commit bc7e471 into apache:main Jun 9, 2023
@potiuk potiuk deleted the fix-skipping-provider-tests-for-non-main-branch branch June 9, 2023 21:21
potiuk added a commit that referenced this pull request Jun 9, 2023
When CI runs in non-main branch, some provider precommits and provider
tests should be disabled. There was a typo that prevented this from
happening, also names of the pre-commits changed.

(cherry picked from commit bc7e471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants