-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run builds on "push" events for v* test branch #31825
Only run builds on "push" events for v* test branch #31825
Conversation
We do not need to run separate build on push and pull request when we are cherry-picking and pushing branch to apache/airflow repo. Those PRs are always made by committers, and they are done as direct push to the apache/airflow repo so they will run build on push (which will be equivalent of canary run). We also do not need to run anything on stable, because stable is the result of merging those changes from test after they get green.
This one will avoid running two builds (one for push and one for pull_request) when we are working on *test branch. |
Another finding from 2.6.2 preparation |
This likely led to "permission error" when two builds at teh same time tried to push the same image in v2-6-test branch |
Doesn't the run on stable update constraint files though? |
Glad you asked :) Nope. The "v*-test" one updates constraints immediately if the test build succeeds. We do not need to defer updating constraints - this is only needed for PR runs (the reason why we do not update constraints for PRs is that they will break other's PRs if pushed too early). This is controlled by "canary-run" flag, which is set by "get-workflow-info":
|
We do not need to run separate build on push and pull request when we are cherry-picking and pushing branch to apache/airflow repo. Those PRs are always made by committers, and they are done as direct push to the apache/airflow repo so they will run build on push (which will be equivalent of canary run). We also do not need to run anything on stable, because stable is the result of merging those changes from test after they get green. (cherry picked from commit 0dddaa0)
We do not need to run separate build on push and pull request when we are cherry-picking and pushing branch to apache/airflow repo. Those PRs are always made by committers, and they are done as direct push to the apache/airflow repo so they will run build on push (which will be equivalent of canary run). We also do not need to run anything on stable, because stable is the result of merging those changes from test after they get green.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.