-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Moves AzureBlobStorageToGCSOperator from Azure to Google provider
#32306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check with redirects.txt if it's possible to add entry to redirect the doc between providers?
I'm not sure if this will work but worth trying.
The goal is that when users try to view this doc in newer provider version they will be forward to the google doc rather than getting 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theorethically it should work if you use ../apache-airlfow-providers-google/operators/...... in the amazon redirects.txt I think , but It might have some side effects especially when one provider package docs is being generated.
If it won't work - we can always manually generate the redirects by modifying the "post-docs.py" script:
https://github.com/apache/airflow-site/blob/main/post-docs/add-back-references.py
This could be our escape hatch for that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! It works with a few extra dots. Added to the redirects.txt, but of course, it would only redirect to the latest version and has to be removed in later versions.
transfer/azure_blob_to_gcs.rst ../../apache-airflow-providers-google/latest/operators/transfer/azure_blob_to_gcs.rst
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ferruzzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request, non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working on enabling rule D205 in the stylechecks which enforces a blank line after the summary, if you don't mind.
| This class is deprecated. | |
| Please use `airflow.providers.google.cloud.transfers.azure_blob_to_gcs.AzureBlobStorageToGCSOperator`. | |
| This class is deprecated. | |
| Please use `airflow.providers.google.cloud.transfers.azure_blob_to_gcs.AzureBlobStorageToGCSOperator`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """This class is deprecated. | |
| Please use | |
| """This class is deprecated. | |
| Please use |
Closes: #32285
AzureBlobStorageToGCSOperatorto Google providerAzureBlobStorageToGCSOperatorin Azure provider^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.