Skip to content

Conversation

@Adaverse
Copy link
Contributor

@Adaverse Adaverse commented Jul 1, 2023

Closes: #32285

  • Moved AzureBlobStorageToGCSOperator to Google provider
  • Deprecated AzureBlobStorageToGCSOperator in Azure provider

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check with redirects.txt if it's possible to add entry to redirect the doc between providers?
I'm not sure if this will work but worth trying.
The goal is that when users try to view this doc in newer provider version they will be forward to the google doc rather than getting 404

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theorethically it should work if you use ../apache-airlfow-providers-google/operators/...... in the amazon redirects.txt I think , but It might have some side effects especially when one provider package docs is being generated.

If it won't work - we can always manually generate the redirects by modifying the "post-docs.py" script:

https://github.com/apache/airflow-site/blob/main/post-docs/add-back-references.py

This could be our escape hatch for that one.

Copy link
Contributor Author

@Adaverse Adaverse Jul 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! It works with a few extra dots. Added to the redirects.txt, but of course, it would only redirect to the latest version and has to be removed in later versions.

transfer/azure_blob_to_gcs.rst ../../apache-airflow-providers-google/latest/operators/transfer/azure_blob_to_gcs.rst

@Adaverse Adaverse requested a review from eladkal July 3, 2023 07:49
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request, non-blocking.

Comment on lines +30 to +31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been working on enabling rule D205 in the stylechecks which enforces a blank line after the summary, if you don't mind.

Suggested change
This class is deprecated.
Please use `airflow.providers.google.cloud.transfers.azure_blob_to_gcs.AzureBlobStorageToGCSOperator`.
This class is deprecated.
Please use `airflow.providers.google.cloud.transfers.azure_blob_to_gcs.AzureBlobStorageToGCSOperator`.

Comment on lines +36 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""This class is deprecated.
Please use
"""This class is deprecated.
Please use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move AzureBlobStorageToGCSOperator to the Google provider

4 participants