Fix breaking change when Active Directory ID is used as host in WASB #32560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
ephraimbuddy
commented
Jul 12, 2023
jedcunningham
approved these changes
Jul 12, 2023
A recent change: apache@46ee1c2, to build account url if not provided broke backward compatibility in Wasb hook by assuming that host is always provided as a fully qualified url. Previously, we generate the account url as the last resort to getting the connection. This change restores the previous behaviour of generating a URL if the host was provided with an ID instead of a URL
pankajkoti
approved these changes
Jul 12, 2023
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
Would we need to yank the earlier release of the provider?
Contributor
Author
I think quickly releasing a patch will suffix |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change: 46ee1c2,
to build account url if not provided broke backward compatibility in Wasb hook by assuming that
host is always provided as a fully qualified url. Previously, we generate the account url
as the last resort to getting the connection.
This change restores the previous behaviour of generating a URL if the host was provided with an ID
instead of a URL