-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arrays of different data types in the Trigger Form UI #32734
Add support for arrays of different data types in the Trigger Form UI #32734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small beautification proposals in documentation, otherwise - I like it! Thanks for the contribution!
(Take my approval emotional, I have no committer status)
9ed9cf4
to
f029ad1
Compare
Great, thanks for the feedback! I've updated the PR with your commits |
Uuups, sorry, my comments were not syntax checked :-( The URL is not correctly formed to be accepted by Sphinx. |
Co-authored-by: Jens Scheffler <95105677+jens-scheffler-bosch@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jens-scheffler-bosch@users.noreply.github.com>
496b0a1
to
808d2bb
Compare
…#32734) * Add JSON field for complex arrays with types other than string --------- Co-authored-by: Matthieu Blais <matthieu.blais@tech.jago.com> Co-authored-by: Jens Scheffler <95105677+jens-scheffler-bosch@users.noreply.github.com> Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com> (cherry picked from commit da69315)
Description
The new Trigger Form UI released in 2.6 is handy but doesn't support
array
params of data types other than string. For more flexibility, this PR proposes to generate a JSON field similar to theobject
param if the users specify the attributeitems
inschema
.How to reproduce the issue
Use an
array
param and require the items to be integers.The Generated Conf JSON shows an array of strings
And we cannot trigger the DAG:
Workaround
We can manually update the Generated Configuration JSON box, but it is not user friendly (especially if we expect an array of objects!), and will become counter intuitive as users get used to the benefits of the new trigger form.
What do you think @jens-scheffler-bosch ?