Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add concrete examples for accessing context variables from TaskFlow tasks #33296

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

RNHTTR
Copy link
Contributor

@RNHTTR RNHTTR commented Aug 10, 2023

A lot of questions come up on StackOverflow about accessing context variables. I think it's a good idea to add a concrete example to both the TaskFlow section on context and to the reference for templates, which is where the actual available variables are documented.

TaskFlow context section

image


Templates reference section

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@dstandish dstandish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some optional suggestions for you

docs/shared/template-examples/taskflow.rst Outdated Show resolved Hide resolved
docs/apache-airflow/core-concepts/taskflow.rst Outdated Show resolved Hide resolved
docs/apache-airflow/templates-ref.rst Outdated Show resolved Hide resolved
@dstandish
Copy link
Contributor

looks like you may need to install pre-commit and re-run it on the files in your branch

@kaxil kaxil merged commit e57d0c9 into apache:main Aug 15, 2023
42 checks passed
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.1 milestone Aug 27, 2023
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants