D205 Support - WWW #33298
Merged
D205 Support - WWW #33298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruzzi
requested review from
jhtimmins,
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:API
uranusjr
reviewed
Aug 11, 2023
Comment on lines
61
to
63
| Add `Deprecation HTTP Header Field. | ||
|
|
||
| See also: <https://tools.ietf.org/id/draft-dalal-deprecation-header-03.html>`__. |
There was a problem hiding this comment.
There’s a link syntax that’s broken here
There was a problem hiding this comment.
Well spotted, thanks.
Turns out the link is dead. I did a search to find the new home of what should be there and it looks like it's an abandoned proposal: https://datatracker.ietf.org/doc/draft-dalal-deprecation-header/
I just updated the link, but maybe we should remove the link entirely?
potiuk
approved these changes
Aug 13, 2023
ferruzzi
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
* D205 Support - WWW * fix broken link
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
* D205 Support - WWW * fix broken link (cherry picked from commit 64c2a56)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10742
D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be a blank line before the rest of the docstring. Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
There are almost a thousand violations in the repo so we're going to have to take this in bites.
PLEASE NOTE
There should be zero logic changes in this PR, only changes to docstrings and whitespace. If you see otherwise, please call it out.
Included in this chunk
All files in the
airflow/wwwmodule.To test
If you comment out this line and run pre-commit in main you will get around 96 errors. After these changes, only 59 remain and none of the above files should be on the list. After uncommenting that line and rerunning pre-commits, there should be zero regressions.