Stop adding values to rendered templates UI when there is no dagrun #33516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
potiuk
force-pushed
the
fix/unsecure_rendered_fields
branch
from
2aeea1e
to
5d76a46
Compare
potiuk
approved these changes
Aug 19, 2023
potiuk
force-pushed
the
fix/unsecure_rendered_fields
branch
from
5d76a46
to
99f75a6
Compare
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33478
When there is no dag run (dag never being run, or wrong execution_date), we create the TI from the raw task, and in this case we load the rendered values as plain values, and there is no way to retrieve the context to correctly redact them. For that it is unsafe to keep the values on the UI where there is no dagrun (no TI in the DB).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.