Sort data before groupby in TIS duration calculation #33535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
potiuk
approved these changes
Aug 19, 2023
|
MArked it as 2.7.1 as well |
uranusjr
reviewed
Aug 20, 2023
potiuk
approved these changes
Aug 20, 2023
uranusjr
reviewed
Aug 21, 2023
airflow/www/views.py
Outdated
Comment on lines
184
to
186
| def _sorted_groupby(it, key: Callable | None = None, reverse: bool = False): | ||
| """Helper around `itertools.groupby`, which pre-sort iterable by the same key.""" | ||
| yield from itertools.groupby(sorted(it, key=key, reverse=reverse), key=key) |
There was a problem hiding this comment.
I’d put this function closer to its usage, maybe nested in duration directly. This is more than 3,000 lines apart!
There was a problem hiding this comment.
Got it. Lets return to initial suggestion, to move into nested function for determine grouping key
There was a problem hiding this comment.
@uranusjr WDYT is it look fine now?
Taragolis
force-pushed
the
sort-groupby
branch
from
7f4f214
to
69c3193
Compare
uranusjr
approved these changes
Aug 24, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 79b8cfc)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itertools.groupby required pre-sorted, otherwise it is possible that multiple same group would created during iteration.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.