Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Irrelevant Dag Processor from Cluster Activity Page #33611

Merged
merged 14 commits into from
Sep 2, 2023

Conversation

erdos2n
Copy link
Contributor

@erdos2n erdos2n commented Aug 22, 2023

Users should not see the Dag Processor health on the Cluster Activity page if standalone_dag_processor=False.

closes: #33497

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 22, 2023
@erdos2n
Copy link
Contributor Author

erdos2n commented Aug 22, 2023

@bbovenzi how can I prevent this error from occurring in the React/WWW tests?

    ReferenceError: standaloneDagProcessor is not defined

@bbovenzi
Copy link
Contributor

@bbovenzi how can I prevent this error from occurring in the React/WWW tests?

    ReferenceError: standaloneDagProcessor is not defined

Look at global.stateColors inside of jest-setup.js

@bbovenzi
Copy link
Contributor

Care to rebase? Not sure why some images aren't building correctly.

@potiuk
Copy link
Member

potiuk commented Aug 23, 2023

I rebased. We had a "botocore" causing backtracking issues (solved today with #33649

@eladkal eladkal added this to the Airflow 2.7.1 milestone Aug 25, 2023
replacing bottom margin with a top margin
removed bottom margin from triggerer
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Re-running the failed job, should be green

@pierrejeambrun pierrejeambrun merged commit c055e1d into apache:main Sep 2, 2023
42 checks passed
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
* first commit

* refactoring

* adding undefined default

* added logic to check if defined

* refactored component

* refactored not equal sign

* refactored code for boolean type instead of string

* refactored global variable. refactored conditional

* pre-commit and linting fixes

* updated jest-setup

* updated jest-setup

* precommit fix

* Update Health.tsx

replacing bottom margin with a top margin

* Update Health.tsx

removed bottom margin from triggerer

(cherry picked from commit c055e1d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAG Processor should not be visible in the Cluster Activity Page if there is no stand alone processor
6 participants