-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AWS Batch waiter failure state #33656
Fix AWS Batch waiter failure state #33656
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, according to botocore code only failure
, success
and waiting
are expected state, unfortunetly Waiters are not documented in boto3 / botocore well
@@ -295,3 +296,58 @@ def test_export_table_to_point_in_time_failed(self, mock_describe_export): | |||
ExportArn="LoremIpsumissimplydummytextoftheprintingandtypesettingindustry", | |||
WaiterConfig={"Delay": 0.01, "MaxAttempts": 3}, | |||
) | |||
|
|||
|
|||
class TestCustomBatchServiceWaiters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Problem
AWS BatchSensor in deferred mode doesn't terminate on job failure and keeps waiting until timing out.
Root cause
In that scenario internally it uses BatchSensorTrigger, which in it's turn uses the
batch_job_complete
waiter.This waiter is wrongly configured to return a
failed
state instead of thefailure
expected by botocore.Scope
This pull request fixes the waiter state and adds tests for it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.