Refactor: path.rglob("…") does not need "**" #33669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumiro
requested review from
potiuk,
ashb,
jedcunningham and
kaxil
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
area:system-tests
kind:documentation
provider:google
eumiro
commented
Aug 23, 2023
| lines = [line.upper() for line in src.readlines()] | ||
| print(lines) | ||
| dest.writelines(lines) | ||
| with f.open() as src: |
There was a problem hiding this comment.
I think this block should be indented, so it happens for every f and not only for the last one. Please review.
There was a problem hiding this comment.
Yes. Google System tests are not yet run regularly. Google team works on automatically running them and providing a dashboard so they would get to this one too.. but we can correct it now.
potiuk
approved these changes
Aug 24, 2023
|
conflicts/tests/ to solve |
eumiro
force-pushed
the
rglob
branch
5 times, most recently
from
568713e
to
b69f7e7
Compare
potiuk
approved these changes
Aug 24, 2023
|
Conflicts now :( |
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 8aa2229)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
path.glob("**/…")withpath.rglob("…"). If the**placeholder is deeper, then extendpath.