Refactor: Replace lambdas with comprehensions #33745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
area:Scheduler
eumiro
changed the title
uranusjr
reviewed
Aug 28, 2023
airflow/jobs/backfill_job_runner.py
Outdated
| sorted_ti_keys = (k[0:4] for k in sorted_ti_keys) | ||
| sorted_ti_keys = [k[0:4] for k in sorted_ti_keys] |
There was a problem hiding this comment.
This does not seem to fit in this PR?
There was a problem hiding this comment.
Oh yes, thanks, removed.
uranusjr
reviewed
Aug 29, 2023
| @@ -357,7 +357,7 @@ def print_async_summary(completed_list: list[ApplyResult]) -> None: | |||
|
|
|||
| def get_completed_result_list(results: list[ApplyResult]) -> list[ApplyResult]: | |||
| """Return completed results from the list.""" | |||
| return list(filter(lambda result: result.ready(), results)) | |||
| return [result for result in results if result.ready] | |||
There was a problem hiding this comment.
Suggested change
| return [result for result in results if result.ready] | |
| return [result for result in results if result.ready()] |
uranusjr
reviewed
Aug 29, 2023
uranusjr
approved these changes
Aug 30, 2023
potiuk
approved these changes
Aug 30, 2023
|
You need to make it ready for review @eumiro |
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 9a0f54d)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.