Improve modules import in Airflow core by some of them into a type-checking block #33755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
jedcunningham,
ephraimbuddy,
dstandish,
kaxil,
potiuk,
ashb,
uranusjr,
jhtimmins,
ryanahamilton,
bbovenzi,
pierrejeambrun,
bolkedebruin,
XD-DENG and
o-nikolas
as code owners
|
I think it's ready, I fixed the wrong import in utils.session, and I reverted the change which update the lazy import logic in the models module. I checked the files one by one, and all looks good. |
hussein-awala
force-pushed
the
fix/core_import
branch
from
c6f2a42
to
edc3d76
Compare
|
This is a huge and potentially conflicting change (thought the conflicts will be easy to solve because those are only import changes. I am a little torn on this one- should we split it inte separate per "package/subpackage" maybe to limit the cherry-picking radius blast ? |
|
I agree, I had the same concern, but I preferred to hear from the reviewers before making this change. |
hussein-awala
force-pushed
the
fix/core_import
branch
from
6166f8e
to
d9b05da
Compare
|
I think we can keep the remaining files in a single PR |
potiuk
approved these changes
Aug 28, 2023
LGTM |
ephraimbuddy
added
the
type:misc/internal
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.