Replace type func by isinstance in fab_security manager #33760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
Lee-W
approved these changes
Aug 26, 2023
potiuk
reviewed
Aug 26, 2023
| @@ -390,7 +390,7 @@ def my_oauth_user_info(sm, provider, response=None): | |||
| def wraps(provider, response=None): | |||
| ret = f(self, provider, response=response) | |||
| # Checks if decorator is well behaved and returns a dict as supposed. | |||
| if not type(ret) == dict: | |||
| if not isinstance(ret, dict): | |||
There was a problem hiding this comment.
It's slightly different meaning, but yes - that's how it should be, so this is really a bugfix (for example the first check would not work if we returned OrderedDict, but the fix would)
potiuk
approved these changes
Aug 26, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit a44f261)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.