-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI DAG counts including deleted DAGs #33778
Conversation
(cherry picked from commit 64948fa)
@Taragolis I just encounter this issue again on 2.7.2. |
@potiuk Tagging you as well for better reach 🙇 |
This change is present in 2.7.2 https://github.com/apache/airflow/blob/2.7.2/airflow/www/views.py#L842C1-L844C24 and you can even check it yourself @boushphong by looking at the code where your airflow is installed (In Python you can always check yourself the code of the application). You can also check it yourself in the packages you install - download them in PyPI, uncompress and see it for yourself . If you have wrong code in your installation, then probably something wrong with your deployment. Maybe your webserver uses different version etc. etc. Please check all of that and if you see that our released package does not have the code, then raise an alarm pointing to that. Can you please do all those check and let us know if you find out that the code did not make it to our packae? No need for maintainers doing it (or being tagged) - since you can do it. Can you help us by doing the checl please @boushphong aand report to us if you find our releases are wrong? |
I don't think this change was in the link you provided.
Yes, I have downloaded both version 2.7.1 and 2.7.2 on PyPi and I can confirm that version 2.7.2 doesn't have the change. 2.7.1 and the main branch do have the change though. Let me open an issue! |
Yes. confirmed that 2.7.2 has this issue. The change however was added back in the main branch after 2.7.2 at: |
Ah cool. Seems to be already marked for 2.7.3 |
I think in Airflow 2.7.2 was added some other bug
So this is a good chance to test it on upcoming 2.7.3 Release Candidate |
closes: #33698
dag
table, without specifically filtering for records with theis_active
flag set toTrue
. Consequently, this selection leads to inaccurate counts.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.