Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI DAG counts including deleted DAGs #33778

Merged
merged 3 commits into from
Aug 27, 2023

Conversation

boushphong
Copy link
Contributor

@boushphong boushphong commented Aug 26, 2023

closes: #33698

  • The All, Active, and Paused counts include deleted DAGs.
  • This situation arises due to the code's current approach of grouping all entries from the dag table, without specifically filtering for records with the is_active flag set to True. Consequently, this selection leads to inaccurate counts.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Aug 26, 2023
@boushphong boushphong changed the title ISSUE-33698: Fix UI DAG counts including deleted DAGs Fix UI DAG counts including deleted DAGs Aug 26, 2023
@potiuk potiuk added this to the Airflow 2.7.1 milestone Aug 27, 2023
@potiuk potiuk merged commit 64948fa into apache:main Aug 27, 2023
42 checks passed
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 28, 2023
ephraimbuddy pushed a commit that referenced this pull request Aug 28, 2023
@Taragolis Taragolis mentioned this pull request Aug 30, 2023
2 tasks
@potiuk potiuk mentioned this pull request Aug 30, 2023
2 tasks
@boushphong
Copy link
Contributor Author

@Taragolis I just encounter this issue again on 2.7.2.
I checked on PyPi and It looks like 2.7.2 doesn't include this change but 2.7.1 does.

@boushphong
Copy link
Contributor Author

boushphong commented Oct 28, 2023

I just encounter this issue again on 2.7.2.
I checked on PyPi and It looks like 2.7.2 doesn't include this change but 2.7.1 does.

@potiuk Tagging you as well for better reach 🙇
Built from main actually works as expected and no issue, but not from pip install apache-airflow==2.7.2. Maybe a faulty build?

@potiuk
Copy link
Member

potiuk commented Oct 28, 2023

This change is present in 2.7.2 https://github.com/apache/airflow/blob/2.7.2/airflow/www/views.py#L842C1-L844C24 and you can even check it yourself @boushphong by looking at the code where your airflow is installed (In Python you can always check yourself the code of the application).

You can also check it yourself in the packages you install - download them in PyPI, uncompress and see it for yourself . If you have wrong code in your installation, then probably something wrong with your deployment. Maybe your webserver uses different version etc. etc.

Please check all of that and if you see that our released package does not have the code, then raise an alarm pointing to that.

Can you please do all those check and let us know if you find out that the code did not make it to our packae? No need for maintainers doing it (or being tagged) - since you can do it. Can you help us by doing the checl please @boushphong aand report to us if you find our releases are wrong?

@boushphong
Copy link
Contributor Author

boushphong commented Oct 28, 2023

This change is present in 2.7.2 https://github.com/apache/airflow/blob/2.7.2/airflow/www/views.py#L842C1-L844C24

I don't think this change was in the link you provided.

You can also check it yourself in the packages you install - download them in PyPI, uncompress and see it for yourself

Yes, I have downloaded both version 2.7.1 and 2.7.2 on PyPi and I can confirm that version 2.7.2 doesn't have the change. 2.7.1 and the main branch do have the change though.

image

Let me open an issue!

@boushphong
Copy link
Contributor Author

Yes. confirmed that 2.7.2 has this issue.

The change however was added back in the main branch after 2.7.2 at:
54e7e08

@potiuk
Copy link
Member

potiuk commented Oct 28, 2023

Ah cool. Seems to be already marked for 2.7.3

@Taragolis
Copy link
Contributor

I think in Airflow 2.7.2 was added some other bug

So this is a good chance to test it on upcoming 2.7.3 Release Candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI DAG counts including deleted DAGs
5 participants