Remove version top-level element from docker compose files
#33831
Conversation
| @@ -44,7 +44,6 @@ | |||
| # | |||
| # Feel free to modify this file to suit your needs. | |||
| --- | |||
| version: '3.8' | |||
There was a problem hiding this comment.
One potential exception it is keep only for docker-compose from documentation
There was a problem hiding this comment.
From https://docs.docker.com/compose/history/
From July 2023 Compose V1 stopped receiving updates. It's also no longer available in new releases of Docker Desktop.
I think it's time we drop compose v1 compatibility also from the documentation one. I think we should just add information in https://airflow.apache.org/docs/apache-airflow/stable/howto/docker-compose/index.html that Only docker compose v2 is supported.
There was a problem hiding this comment.
People always can download old compose from previous Airflow versions.
Taragolis
force-pushed
the
remove-docker-compose-version
branch
from
59f81b4
to
8fe08ad
Compare
| @@ -35,7 +35,7 @@ This procedure assumes familiarity with Docker and Docker Compose. If you haven' | |||
| Follow these steps to install the necessary tools, if you have not already done so. | |||
|
|
|||
| 1. Install `Docker Community Edition (CE) <https://docs.docker.com/engine/installation/>`__ on your workstation. Depending on your OS, you may need to configure Docker to use at least 4.00 GB of memory for the Airflow containers to run properly. Please refer to the Resources section in the `Docker for Windows <https://docs.docker.com/docker-for-windows/#resources>`__ or `Docker for Mac <https://docs.docker.com/docker-for-mac/#resources>`__ documentation for more information. | |||
| 2. Install `Docker Compose <https://docs.docker.com/compose/install/>`__ v1.29.1 or newer on your workstation. | |||
| 2. Install `Docker Compose <https://docs.docker.com/compose/install/>`__ v2.14.0 or newer on your workstation. | |||
There was a problem hiding this comment.
I couldn't come up with anything better here rather than pick up current MIN_DOCKER_COMPOSE_VERSION for CI/Breeze 🤣 At least we run compose tests by use 2.14
There was a problem hiding this comment.
That's a very good one. I even explained that very minimum is coming in this PR today to a user in Slack
This is optional field since compose 1.27. We use internally compose v2, so I do not see viable reason to keep it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.