Add TCH001 and TCH002 rules to pre-commit to detect and move type checking modules #33865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
potiuk,
ashb,
jedcunningham,
eladkal and
o-nikolas
as code owners
boring-cyborg
bot
added
area:API
|
@potiuk do we cherry-pick dev and tests? is it ok to keep all these changes in the same PR or should I split them in smaller ones? |
hussein-awala
changed the title
uranusjr
reviewed
Aug 29, 2023
uranusjr
reviewed
Aug 29, 2023
uranusjr
reviewed
Aug 31, 2023
uranusjr
approved these changes
Aug 31, 2023
We do cherry-pick dev and tests except providers (we might cherry-pick some of them accidentally) - but I think with the current state of 2.7 this does not matter any more :D |
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.