Raise 404 from Variable PATCH API if variable is not found #33885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekbhakat
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
|
Is it possible to add a test for that one? Should be easy following other tests in https://github.com/apache/airflow/tree/main/tests/api_connexion/endpoints. - and at the same time you will be able to see if removing your new code will trigger the error (thus giving ultimate certainty it's the solution) ? |
|
@potiuk, I added the test. And tried with removing the code, below is the result with test failing. Also didn't wanted to leave the |
uranusjr
approved these changes
Aug 30, 2023
uranusjr
changed the title
ephraimbuddy
approved these changes
Aug 30, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Raise variable not found if session returns empty * Added detail to the exception for json reponse * tests for patch api when variable doesn't exist * Dropped fstring * Unify varialbe not found message --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 701c3b8)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise NotFound exception if variable search via session returns empty.
A possible fix for Issue.
closes: #33871