Cleanup: remove remnants of 'shutdown' task instance state #33893
Conversation
Bisk1
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
potiuk
as code owners
boring-cyborg
bot
added
area:UI
| @@ -76,7 +76,6 @@ The possible states for a Task Instance are: | |||
| * ``queued``: The task has been assigned to an Executor and is awaiting a worker | |||
| * ``running``: The task is running on a worker (or on a local/synchronous executor) | |||
| * ``success``: The task finished running without errors | |||
| * ``shutdown``: The task was externally requested to shut down when it was running | |||
There was a problem hiding this comment.
Should a note be added below this list to mention there used to be a shutdown state but not anymore?
There was a problem hiding this comment.
I felt like it's not useful information because users of new version won't see 'shutdown' state and if someone has older version they should look at relevant, older docs. There probably should be an update in release notes though. But I can modify it if you're sure.
There was a problem hiding this comment.
We discussed it in #33746 and it turned out that SHUTDOWN not only has been deeply buried and nearly forgotten but also it has never been working for things like API. So I think I would prefer to pretend it never existed :P
|
We need also to update the diagram in the page |
Diagram has been already updated in the previous PR :) |
ephraimbuddy
added
the
type:misc/internal
Co-authored-by: daniel.dylag <danieldylag1990@gmail.com> (cherry picked from commit b37eaae)
Follow-up of #33746 - several mentions of 'shutdown' task were left behind, e.g. in docs
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.